-
Notifications
You must be signed in to change notification settings - Fork 14
fix: refactor presets import to use JSON module syntax #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
styfle
commented
Nov 3, 2025
- Related to Is this package server-only? Unable to use with Vite 5 #512
Summary of ChangesHello @styfle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the way JSON preset files are imported within the codebase. It transitions from using a CommonJS-style Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the JSON preset import to use modern ESM syntax. I've identified a potential compatibility issue with the chosen with keyword for import attributes, as it requires very recent Node.js versions. I've left a comment with a suggestion to use the assert keyword instead, which has wider support and aligns with the original proposal in issue #512. This change will help maintain broader compatibility for the library's users.
UziTech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like nyc coverage is failing. I'm ok with just removing it since we don't block on coverage or do much with it anyway.
Removed Coverage job from GitHub Actions workflow and updated Release job dependencies.
|
Ok sounds good. I removed the CI action for now. We can look into updating the dependencies in the future if we want to try coverage again. |
UziTech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 💯
## [5.0.3](v5.0.2...v5.0.3) (2025-11-04) ### Bug Fixes * refactor presets import to use JSON module syntax ([#516](#516)) ([155c7c5](155c7c5))