Skip to content

Conversation

@styfle
Copy link
Member

@styfle styfle commented Nov 3, 2025

@styfle styfle requested a review from UziTech November 3, 2025 19:44
@gemini-code-assist
Copy link

Summary of Changes

Hello @styfle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the way JSON preset files are imported within the codebase. It transitions from using a CommonJS-style require function, which was created via createRequire, to the more modern ES Module import syntax, specifically leveraging the with { type: 'json' } assertion. This change modernizes the module loading for JSON assets, aligning the project with contemporary JavaScript module standards and improving consistency in module handling.

Highlights

  • Refactor JSON Import: Updated the import mechanism for JSON preset files from using createRequire to the modern ES Module import statement with type: 'json' assertion.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the JSON preset import to use modern ESM syntax. I've identified a potential compatibility issue with the chosen with keyword for import attributes, as it requires very recent Node.js versions. I've left a comment with a suggestion to use the assert keyword instead, which has wider support and aligns with the original proposal in issue #512. This change will help maintain broader compatibility for the library's users.

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like nyc coverage is failing. I'm ok with just removing it since we don't block on coverage or do much with it anyway.

Removed Coverage job from GitHub Actions workflow and updated Release job dependencies.
@styfle styfle requested a review from UziTech November 4, 2025 15:43
@styfle
Copy link
Member Author

styfle commented Nov 4, 2025

Ok sounds good. I removed the CI action for now. We can look into updating the dependencies in the future if we want to try coverage again.

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯

@UziTech UziTech merged commit 155c7c5 into master Nov 4, 2025
5 checks passed
@UziTech UziTech deleted the styfle/json-import branch November 4, 2025 16:27
github-actions bot pushed a commit that referenced this pull request Nov 4, 2025
## [5.0.3](v5.0.2...v5.0.3) (2025-11-04)

### Bug Fixes

* refactor presets import to use JSON module syntax ([#516](#516)) ([155c7c5](155c7c5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants