Add --disable-host-check to allow external access #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Since this isn't a production supported feature yet, I'm going to allow this through. We'll need to discuss having this only happen during development environments in the future if this extends to production use. |
aebadirad
approved these changes
Mar 3, 2018
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing and running QuickStart on an ML VM, I couldn't access that QuickStart app from my remote machine, i.e. via:
http://engrlab-129-036.engrlab.marklogic.com:4200/
Adding --disable-host-check to the "ng serve" command fixed this:
ng serve -pc proxy.config.json --host 0.0.0.0 --disable-host-checkThis is discussed here:
https://stackoverflow.com/questions/43677629/invalid-host-header-when-running-angular-cli-development-server-c9-io
There are reported security implications:
https://medium.com/webpack/webpack-dev-server-middleware-security-issues-1489d950874a
Note that I was not able to solve the issue by adding a --public option (with marklogic.com or *.marklogic.com) instead, which is mentioned in the above article.