Add changeWidth param to allow animating width
#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was only possible to animate the height of the component. This adds the possibility to animate width together with height. Width change animation can be enabled by passing in `changeWidth: true` in props for the component. This change is backwards compatible.
wifilinker
force-pushed
the
change_width
branch
from
38b9cd2 to
decc1ae
Compare
|
Thanks for contributing this. I will merge it soon and publish as is, and then I will also be releasing yet another rewrite of the component to solve some other issues (which will also include height animation). I want to release it all in one go, and I need to do a bit more testing on the rewrite before it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was only possible to animate the height of the component.
This adds the possibility to animate width together with height.
Width change animation can be enabled by passing in
changeWidth: truein props for the component.
This change is backwards compatible.