Skip to content

Conversation

marnusw
Copy link
Owner

@marnusw marnusw commented Mar 8, 2017

This is a complete rewrite of the component which more closely matches react-addons-css-transition-group. The implementation is more stable and solves some past idiosyncrasies. (#29, #38)

This branch can be installed as version 3.0.0-beta.1

Outstanding items before this branch will be ready to merge:

  • Add the option to animate width back in as in Add changeWidth param to allow animating width #31.
  • Add an option to prevent a second animation from being initiated while a previous animation is in progress. (This component used to work this way before Improve behavior of transitionLeave=false and height transition #34 was merged.) (This actually doesn't seem like a great idea; if this is needed it seems the parent component should prevent state changes since this component can't just ignore changing children. The parent not knowing whether a transition is active or not won't make this easy, but that is a different problem.)
  • When starting a 2nd animation while a previous component is still entering that animation is cancelled and the leave animation starts immediately causing a jerk.

@marnusw marnusw merged commit 3f9a4ca into master Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant