Improve behavior of transitionLeave=false and height transition #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously transitionLeave being false did not affect the behavior and in dom the old component still existed together with the new component. This does not show old component at all when new component is ready to be rendered.
When transitionLeave is set to false, it might happen that current component is not yet rendered when a new component reaches this part of the code. At this point we want to use the height and width of the latest rendered elment.
Similarly to ReactCSSTransitionGroup, adding `-height-active` suffix to the container when we are transitioning height.
|
Thanks a million for all these improvements @wifilinker! I'm sorry it took so long for me to review. |
marnusw
added a commit
that referenced
this pull request
Feb 27, 2017
This was referenced Feb 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
transitionLeave=false, this change makes the container to not render leaving component at all.Additionally it adds
{animation-name}-height-activeclass to the container right after the{animation-name}-heighthas been added.