Shared deposit cap #280
Merged
Shared deposit cap #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larry0x
commented
Jul 29, 2023
piobab
reviewed
Jul 30, 2023
piobab
approved these changes
Jul 31, 2023
brimigs
approved these changes
Jul 31, 2023
Move tests from base to osmosis Implement IbcTransferMsg abstraction Implement mars-rewards-collector-neutron Add neutron config to update msg. Disable github pipeline.
* Add account_id for rover deposit rewards. * Use user addr and account id as compound key. * Apply comments.
larry0x
force-pushed
the
shared-deposit-cap-2
branch
from
c43f057 to
8082f24
Compare
larry0x
force-pushed
the
shared-deposit-cap-2
branch
from
8082f24 to
591251e
Compare
|
Moved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mars-red-bankto amars-interest-ratelibraryMarketquery to returnOption<Market>;Noneif there no market is found for the given denomTotalDepositquery tomars-paramsthat computes the total amount of a denom deposited across Red Bank and Rover. NOTE: we only account for spot holding; we don't consider LP tokens or vaults, which we have concluded as infeasible after discussions.depositfunction to assert deposit cap is not exceeded.