GitHub: copy and download button broken #90
Comments
|
same here, since about a week. the output of CI actions is also no longer visible. |
Yes, it's been officially announced: https://github.blog/2023-05-08-github-code-search-is-generally-available/
... At the time of this writing, non-signed-in GitHub members are still being served the old/UXP-fully-compatible https://github.com/martok/palefill/blob/master/lib/polyfills.js Good news is the next official Pale Moon/Basilisk release will be able to handle properly GH's |
Good to know! Unfortunately, not being signed in is not a realistic option for me. ;-)
Not sure we'll have to wait that long. I also reported it in the official feedback thread and there is the suggestion that they may have a fix and will be rolling it out in the next few days. |
... IIANM. official Pale Moon 32.2.0 will be released imminently; tag 32.2.0_RC1 was cut just 2 days ago 😉 ... Later edit: PM 32.2.0_Release was tagged on May 15th and released in binary formats on May 16th... BTW, my previous report was from the Serpent 52[/55] UXP-based unofficial/unbranded (Basilisk) forks (built from [forked]UXP
This issue of the partially displaying/vanishing (long) code under UXP isn't reproducible by me on Chromium 86+ forks currently; OTOH, UXP isn't officially supported by GitHub/MS actually (only latest Chromium-based flavours like Google Chrome, Opera, Edge, etc. and latest Firefox stable/ESR), so I'm a bit puzzled that GH employee (AdamSchwert) in the linked discussion never queried you about the browser you're on... Let's hope the "fix" they have in the oven won't further break UXP when it goes live... And speaking of future GH breakages under UXP, if you go and enable (under Feature Preview) the
|
|
Yeah, I sometimes try those Feature Previews, but most of the time I revert that quite quickly as the user experience only degrades. Thanks for the update on the status of the next PaleMoon release. |
Agreed 100% ; still, they'll eventually push whatever new GUI crap (best tailored for mobile devices) down our throats 😡 , with no way of reverting back - breaking along the way many user customisations (e.g. userstyles, userscripts) based around the previous GUI 😞 ...
|
|
Seems to be a missing ECMAScript feature/API perhaps? Following error message are produced when trying to clicking on mentioned element:
(https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement) |
|
... Many thanks for your input 😄 , I'm aware... BTW, I fully agree with your comment below 😉 : https://github.com/orgs/community/discussions/52083#discussioncomment-5898431 Regards 😸 ... |
|
I don't see anything obviously wrong anymore, apart from being horribly slow and looking like metabolic end-product. Can you confirm? |
|
@martok I just upgraded to the latest Palemoon and yes, that does fix the original problem. I agree it is excruciatingly slow when clicking on another file in the navigation pane and from what I have seen, it never actually loads that next file, but shows an error instead and you have to do an F5 page refresh for the next file to actually show, so yes, original problem fixed, but the new GH code view is still hugely problematic from a usability point of view. (but that's not a problem which Palefill can fix, or am I wrong ?) |
... A multitude of things are currently broken under UXP-based browsers with the "new" Code View MS unleashed on May 8th 😡 ... For starters, to mitigate their new CSS code pushed to all on May 3rd (see UXP #2230), I'm using now below uBlock Origin custom filter: With that out of the way, one has to simply visit (being signed-in) a "file code" page, to witness several breakages, e.g.: https://github.com/martok/palefill/blob/master/.gitignore
Add to the above the non-functioning So, what I can confirm is breakage... Regards. |
Works for me.
Surprisingly, that's not because of if (event.button === 2) {
event.preventDefault()
event.stopPropagation()
return
//it was a right click
}
Works right up to the point where it should do the copy because of some old permission issue.
Not here, but also doesn't offer the file for download.
Kinda off-Topic, github.dev never worked in PM. |
|
Thanks for your answers 👍 ; BTW, if it wasn't clear at first, all my "breakage" reports contained here were produced with
As I wrote already, it works as planned in Firefox (113.0.1) too, so is it again a case of a bug Mozilla opted ("chrome-parity") to adopt from Google?
Are you saying it works for you?
It isn't supposed to; in Firefox (113.0.1/Win7SP1x64), when clicked, it produces a tooltip saying
Well. probably 😜 ; but before the recent UXP developments (implementation of logical assignment operators, on which you worked 👍 ), One last thing: What is your expert view on running Kindest greetings. |
I have the native WC implementation and "polifill" turned on - I didn't notice any major problems (except cosmetics, but that's a different story), I think he chooses selectively, what is needed in a given version. |
|
Serpent v52.9.0 (2023-05-12) (32-bit): After installing and enabling
has been fixed 👍 ; thanks ❤️ ; all the rest (2, 3, 4, 5 here) persist... |
This comment was marked as off-topic.
This comment was marked as off-topic.
Maybe. The code explicitly calls
No error message, but doesn't work either. Both buttons request the file contents, but "copy" fails due to the clipboard permission issue and "download" just... doesn't do anything, with no error.
Correct, @AroKol78. The whole concept of a "polyfill" is that it only becomes active when it is required and doesn't do anything if not (but by actual "feature tests", not just "given version"). Additonally, Palefill tries to be smart and only inject the code if it expects it to do anything (the "superseding" mechanism). For example in the latest release we never inject the 20kB of Darktree if it looks like native WebComponents are available. And even before that, they weren't activated in that case.
Correct again. Unless that has somehow changed, in which case let me know and we can disable the disabling. |
Here's the tooltip generated when I press the
|
|
This set of user scripts re-enables broken or non-existent tooltips when JS is disabled and bypasses the broken and pointless fake tooltip system when JS is enabled: /* add title attribute to the parent of every <tool-tip> */
for (let ss of document.querySelectorAll('tool-tip[for]')) {
let ll = document.getElementById(ss.getAttribute('for'));
if (ll && !ll.hasAttribute('title')) {
ll.setAttribute('title', ss.textContent);
}
}
/* let's do the same for <relative-time> */
for (let ss of document.querySelectorAll('*>relative-time[datetime]')) {
if (!ss.hasAttribute('title')) {
ss.setAttribute('title', ss.getAttribute('datetime'));
}
}
/* remove popover attributes to disable JS tooltips that obscure the parent element FFS */
for (let ss of document.querySelectorAll('tool-tip[popover]')) {
ss.removeAttribute('popover');
} |
martok
changed the title
GitHub is rolling out a new code view and it is very very broken....
The start of the page appears to load okay:
But as soon as you scroll down, the view looks empty...
The code does appears to be there, just not visible, which isn't very useful:
I'm seeing the following error in the console:
The text was updated successfully, but these errors were encountered: