feat: add tests using refined version of the prompt #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oycyc
previously approved these changes
Jul 30, 2025
oycyc
left a comment
oycyc
left a comment
There was a problem hiding this comment.
Initial impression, it's mostly declarative and that's a lot of cases and tests for just couple lines of Terraform in the source. But going through the tests, it all makes sense and covers every situation/case deeply.
But there's not much logic in this module not much to test so it makes sense. It's nice to have these tests in place so in the future if we make changes, there's an easy way to validate these.
Member
Author
|
@oycyc thanks for taking a look at the generated code. Yeah, I agree it's a bit verbose. I refined the tests while keeping the same test coverage. |
oycyc
approved these changes
Aug 5, 2025
gberenice
added a commit
that referenced
this pull request
Aug 18, 2025
🤖 I have created a release *beep* *boop* --- ## [0.2.0](0.1.0...v0.2.0) (2025-08-18) ### Features * add tests using refined version of the prompt ([#12](#12)) ([d67932e](d67932e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: masterpointbot[bot] <177651640+masterpointbot[bot]@users.noreply.github.com> Co-authored-by: Veronika Gnilitska <30597968+gberenice@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what