fix: select an asset without prior hover #23

mateuszJS · 2025-07-08T23:17:26Z

Summary by CodeRabbit

New Features
- Added an integration test to verify basic asset transformations, including selection, movement, rotation, and scaling, with visual validation via screenshots.
Optimization
- Improved rendering performance by executing picking logic only when the pointer position changes, reducing unnecessary computations.
Enhancements
- Improved pointer event handling for more accurate asset interaction.
- Added internal callback mechanism for more precise processing of pointer down events.

coderabbitai · 2025-07-08T23:17:32Z

Caution

Review failed

The pull request is closed.

Walkthrough

A new Playwright integration test was added to verify asset transformation interactions in the UI. Internally, the picking and pointer event handling logic was refactored: pointer state now includes a callback for mouse down events, and picking operations in the render loop are optimized to run only when the pointer moves, reducing redundant GPU work.

Changes

Files/Groups	Change Summary
integration-tests/tests/asset-basic-transform.spec.ts	Added Playwright test for basic asset transformations (move, rotate, scale) with screenshot checks.
src/WebGPU/pointer.ts	Extended pointer state with `downCallback`; refactored mousedown handling to use callback.
src/WebGPU/pick.ts	Modified `asyncPick` to invoke `pointer.downCallback` after pick ID read, then reset the callback.
src/run.ts	Optimized picking: picking pass now runs only if pointer position changed since last frame.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Browser (Playwright)
    participant App (Canvas/UI)
    participant Pointer
    participant PickManager

    User->>Browser (Playwright): Uploads image, interacts with canvas
    Browser (Playwright)->>App (Canvas/UI): Simulates mouse events (down/move/up)
    App (Canvas/UI)->>Pointer: Receives mousedown, updates pointer, sets downCallback
    App (Canvas/UI)->>PickManager: Triggers asyncPick if needed
    PickManager->>Pointer: Calls downCallback after pick ID is read
    Pointer->>App (Canvas/UI): Executes on_pointer_down logic

sequenceDiagram
    participant RenderLoop
    participant Pointer
    participant PickManager

    RenderLoop->>Pointer: Check current pointer position
    alt Pointer moved
        RenderLoop->>PickManager: Run picking pass
        PickManager-->>RenderLoop: Return pick result
        RenderLoop->>Pointer: Update lastPickPointer
    else Pointer not moved
        RenderLoop-->>RenderLoop: Skip picking pass
    end

Suggested labels

released on @next

Poem

A bunny hops with careful cheer,
New tests for assets now appear!
Pointer’s smarter, picking’s lean,
Only moves will paint the scene.
With screenshots snapped and code refined,
Our burrow’s faster, well-designed!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-07-08T23_19_21_965Z-debug-0.log

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d1ac806 and 6539d02.

⛔ Files ignored due to path filters (6)

integration-tests/tests/asset-basic-transform.spec.ts-snapshots/move-image-chromium.png is excluded by !**/*.png
integration-tests/tests/asset-basic-transform.spec.ts-snapshots/rotate-image-chromium.png is excluded by !**/*.png
integration-tests/tests/asset-basic-transform.spec.ts-snapshots/select-image-chromium.png is excluded by !**/*.png
integration-tests/tests/asset-basic-transform.spec.ts-snapshots/upload-image-chromium.png is excluded by !**/*.png
integration-tests/tests/asset-basic-transform.spec.ts-snapshots/use-top-left-scale-ui-chromium.png is excluded by !**/*.png
integration-tests/tests/asset-basic-transform.spec.ts-snapshots/use-top-scale-ui-chromium.png is excluded by !**/*.png

📒 Files selected for processing (4)

integration-tests/tests/asset-basic-transform.spec.ts (1 hunks)
src/WebGPU/pick.ts (1 hunks)
src/WebGPU/pointer.ts (2 hunks)
src/run.ts (3 hunks)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-07-08T23:20:51Z

🎉 This PR is included in version 0.1.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

select an asset witout prior hover

6539d02

mateuszJS merged commit 841ed33 into next Jul 8, 2025
3 of 4 checks passed

github-actions bot added the released on @next label Jul 8, 2025

coderabbitai bot mentioned this pull request Aug 23, 2025

feat: refactor of whole shape feature #135

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: select an asset without prior hover #23

fix: select an asset without prior hover #23

Uh oh!

mateuszJS commented Jul 8, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 8, 2025 •

edited

Loading

Review failed

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

github-actions bot commented Jul 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: select an asset without prior hover #23

fix: select an asset without prior hover #23

Uh oh!

Conversation

mateuszJS commented Jul 8, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Suggested labels

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

github-actions bot commented Jul 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mateuszJS commented Jul 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)