-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Draw shape #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Draw shape #44
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new shape drawing feature using cubic Bézier curves in WebGPU. The implementation includes a complete rendering pipeline for drawing complex shapes with both fill and stroke rendering using signed distance fields (SDF).
- Adds a new
drawShapeWebGPU rendering program with sophisticated SDF-based shape evaluation - Implements cubic Bézier curve processing with analytical closest point finding and winding number calculation
- Updates shader naming conventions from
worldViewProjectiontocameraProjectionfor consistency
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/run.ts | Integrates drawShape function and defines test curve data |
| src/WebGPU/programs/initPrograms.ts | Exports and initializes the new drawShape program |
| src/WebGPU/programs/drawTexture/shader.wgsl | Updates uniform naming for consistency |
| src/WebGPU/programs/drawShape/shader.wgsl | Complex shader implementing SDF-based shape rendering |
| src/WebGPU/programs/drawShape/getProgram.ts | WebGPU program setup and rendering logic |
| src/WebGPU/programs/drawShape/getBoundingBox.ts | Calculates precise bounding boxes for cubic Bézier curves |
| src/WebGPU/pointer.ts | Adds pointer update to wheel event handler |
No description provided.