-
Notifications
You must be signed in to change notification settings - Fork 0
fix: Cache drawn shapes #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements shape caching functionality to improve rendering performance by caching drawn shapes as textures and reusing them instead of redrawing the vector shapes each frame.
- Adds texture caching system that renders completed shapes to textures
- Refactors shape rendering to use cached textures when available, falling back to vector rendering during editing
- Updates shape completion flow to generate cached textures automatically
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/textures.ts | Adds setTexture function to store cached textures |
| src/run.ts | Refactors render pass management for texture cache rendering |
| src/logic/shapes/shapes.zig | Implements shape caching logic and texture size management |
| src/logic/shapes/bounding_box.zig | Refactors bounding box calculation to return struct instead of vertices |
| src/logic/index.zig | Integrates cache callbacks and updates render scale handling |
| src/index.ts | Connects cache callbacks and updates initialization |
| src/getMultisampleTexture.ts | Removes duplicate texture creation code |
| src/WebGPU/textureCache.ts | Implements texture cache rendering system |
| src/WebGPU/pointer.ts | Updates imports and function calls |
No description provided.