feat: loads svg from file into shape #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
mateuszJS
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR transforms SVG texture handling by parsing SVG files and extracting shapes instead of treating them as image textures. The key changes involve replacing the texture-based SVG system with a shape-based vector rendering approach.
- Removes SVG texture caching and resizing infrastructure
- Adds SVG parsing to extract paths as shape data
- Refactors shape system to support multiple paths and improved structure
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/textures.ts | Replaces SVG texture handling with shape parsing using svg-parser |
| src/parsePathData.ts | New file implementing SVG path data parsing and conversion to shape data |
| src/logic/shapes/shapes.zig | Major refactor to support multiple paths per shape with improved architecture |
| src/logic/shapes/paths.zig | New file implementing individual path handling within shapes |
| src/logic/svg_textures.zig | Removed - obsolete SVG texture management system |
| src/logic/shared.zig | New shared state for render scale access |
| src/logic/index.zig | Updated to use new shape system and removed SVG texture calls |
Comments suppressed due to low confidence (4)
src/textures.ts:68
- [nitpick] The variable name
svgRootNodeis misleading since it can be either a RootNode or null. Consider renaming tosvgRootNodeOrNullorparsedSvgto better reflect its nullable nature.
getImageWithDetails(url).then(([img, svgRootNode]) => {
src/parsePathData.ts:62
- Use strict equality
===instead of loose equality==for comparison.
}
src/logic/shapes/paths.zig:79
- [nitpick] The panic message should be more descriptive and include context about what the caller should do instead. Consider: "Cannot add point to closed path. Create a new path or reopen the existing path first."
@panic("Attempting to add point to already closed path!");
src/logic/shapes/shapes.zig:107
- [nitpick] The function name
addPointStartis unclear. Consider renaming toaddPointoraddPointToActivePathto better convey its purpose.
pub fn addPointStart(self: *Shape) !void {
mateuszJS
added a commit
that referenced
this pull request
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.