Fix problem with Styles handling of margin. (mathjax/MathJax#3443) #1362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem where margin CSS styles aren't properly handled by the
Styles
object. This is becausemargin
wasn't set in theconnections
array, so settingmargin
didn't propagate tomargin-left
, etc. This means that whenmargin-left
was set earlier and thenmargin
is set to''
later, themargin-left
setting is not cleared. That lead to extra margin settings in the example given in mathjax/MathJax#3443.This PR adds the
margin
connections, and adds more tests for margins, and for overriding connections when the main property is set.It also checks that the left and right margins aren't zero when setting them for shifting the output in the CHTML
Wrapper
object. This is just to keep the CSS minimal.