fixed attribute parsing in properties methods and events #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @apozharski - I wanted to check back to see if there are any plans for this PR? If not, I will close this PR. |
|
Ah, my apologies, I got very busy and this fell off the back of the TODO list. Thanks for the reminder. Let me take a look this week at how close this was to something that could be merged, which I presume at least will involve getting tests in working order. |
|
No worries! Thank you! |
apozharski
force-pushed
the
fixing-attribute-parsing-everywhere
branch
from
203681d to
bcaa109
Compare
apozharski
force-pushed
the
fixing-attribute-parsing-everywhere
branch
from
bcaa109 to
9756824
Compare
apozharski
changed the title
dklilley
approved these changes
Dec 4, 2024
dklilley
added
the
CLA signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the work in #88 to also improve parsing of
property,events, andmethodsblocks.WIP until tests are updated.