update cartopy download URL
#74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Sep 30, 2021
|
Why would we not just use the latest Cartopy that has the correct URL? |
|
Good question. While |
|
Ah, I see we aren't using conda for the build, so that would make that difficult. Though it is preferable to update Cartopy soon, I'm not sure it will have much other effect on the results. You can actually download the current script and pre-download instead of modifying Cartopy settings. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dataset that
cartopydownloads comes from a CDN (http://naciscdn.org/) that goes down intermittently. The dataset is also hosted on S3, and this PR updates the download URL to point to the S3 source (cf. SciTools/cartopy#1325 (comment)).