Skip to content

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented May 5, 2022

Fixes https://github.com/dstansby/napari-matplotlib/issues/11

Still to do:

  • Add a test
  • Add hooks to the spin box widgets to update the plots
  • Add hook to update the viewer z value when the z spin box is updated

@codecov-commenter
Copy link

Codecov Report

Merging #29 (23d7531) into main (043ffb3) will decrease coverage by 18.93%.
The diff coverage is 38.98%.

@@             Coverage Diff             @@
##             main      #29       +/-   ##
===========================================
- Coverage   92.59%   73.65%   -18.94%     
===========================================
  Files           7        8        +1     
  Lines         108      167       +59     
===========================================
+ Hits          100      123       +23     
- Misses          8       44       +36     
Impacted Files Coverage Δ
src/napari_matplotlib/base.py 100.00% <ø> (ø)
src/napari_matplotlib/slice.py 37.93% <37.93%> (ø)
src/napari_matplotlib/__init__.py 71.42% <100.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 043ffb3...23d7531. Read the comment docs.

@dstansby dstansby changed the title SliceSelector Add SliceSelector May 7, 2022
@dstansby dstansby merged commit 5e477b0 into main May 7, 2022
@dstansby dstansby deleted the slice branch May 7, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 1D slice widget
2 participants