Disable keepAlive in download-lib.js, allowing node bindings to work on Node.JS 19 #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 73.07% // Head: 73.07% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1164 +/- ##
=======================================
Coverage 73.07% 73.07%
=======================================
Files 110 110
Lines 12304 12304
=======================================
Hits 8991 8991
Misses 3313 3313 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1160
This is fixed more formally in hgouveia/node-downloader-helper#92, but since it's easy to do without an upstream change I've added the config in here too. Once this gets merged and released, Node.JS 19 users should be able to download the latest binary.