Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve static type checking #336

Merged
merged 8 commits into from
Apr 24, 2023
Merged

Improve static type checking #336

merged 8 commits into from
Apr 24, 2023

Conversation

dklimpel
Copy link
Contributor

Signed-off-by: Dirk Klimpel dirk@klimpel.org

@dklimpel dklimpel marked this pull request as ready for review April 23, 2023 09:29
@dklimpel dklimpel requested a review from a team as a code owner April 23, 2023 09:29
DMRobertson
DMRobertson suggested changes Apr 23, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks. Just a few comments:

sygnal/helper/context_factory.py Show resolved Hide resolved
sygnal/helper/context_factory.py Outdated Show resolved Hide resolved
sygnal/helper/proxy/connectproxyclient_twisted.py Outdated Show resolved Hide resolved
sygnal/helper/proxy/proxyagent_twisted.py Show resolved Hide resolved
DMRobertson
DMRobertson approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@DMRobertson DMRobertson merged commit 3163b07 into matrix-org:main Apr 24, 2023
@dklimpel dklimpel deleted the type_hints branch April 24, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dklimpel @DMRobertson