-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FCM v1: use async version of google-auth and add HTTP proxy support #372
Conversation
Another kick is required to trigger the workflows, this is annoying. @devonh if you can trigger them again please 🙏 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this out locally and it does appear to fix the proxy issue.
I'm just double checking with the team whether we are okay with using the experimental aiohttp support from the google-auth library.
Otherwise there are just a few small changes requested.
Thanks for the fast review. I've address the comments and also differentiate the error cases for |
Also perhaps an useful info, this is deployed in our preprod (with an HTTP proxy) with no trouble. |
This is looking good. Would you be able to add a couple of unit tests? Once those are in place I am comfortable with merging this. |
I've added a fake service account file to test loading, and create a Unfortunately |
Thank you for adding the tests. |
Fix #371.