Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Long-running /context request on matrix.org after client disconnected #14443

Closed
MadLittleMods opened this issue Nov 14, 2022 · 1 comment
Closed
Labels
A-Context-Endpoint /context client API endpoint A-Database DB stuff like queries, migrations, new/remove columns, indexes, unexpected entries in the db A-Performance Performance, both client-facing and admin-facing T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Nov 14, 2022

Follow-up to https://github.com/vector-im/sre-internal/issues/1689 as mentioned by @reivilibre,

There was a /context request that ran for 12345.92s (3.4 hours) in Matrix HQ (!OGEhHVWSdvArJzumhm:matrix.org) but the client disconnected after 180s (client timeout). This would be a good endpoint candidate to make cancelable (@cancellable).

While the /context request ran, it also degraded database performance for the whole client_reader worker so we could limit the exposure by making it cancel on client disconnect. Plus we're doing work for nothing.


In the same vein as #14290 for /search

@MadLittleMods MadLittleMods added A-Performance Performance, both client-facing and admin-facing A-Context-Endpoint /context client API endpoint A-Database DB stuff like queries, migrations, new/remove columns, indexes, unexpected entries in the db labels Nov 14, 2022
@erikjohnston
Copy link
Member

I think this was fixed by #14461

@MadLittleMods MadLittleMods added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Context-Endpoint /context client API endpoint A-Database DB stuff like queries, migrations, new/remove columns, indexes, unexpected entries in the db A-Performance Performance, both client-facing and admin-facing T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

No branches or pull requests

2 participants