This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Long-running /context
request on matrix.org
after client disconnected
#14443
Labels
A-Context-Endpoint
/context client API endpoint
A-Database
DB stuff like queries, migrations, new/remove columns, indexes, unexpected entries in the db
A-Performance
Performance, both client-facing and admin-facing
T-Defect
Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Follow-up to https://github.com/vector-im/sre-internal/issues/1689 as mentioned by @reivilibre,
There was a
/context
request that ran for 12345.92s (3.4 hours) in Matrix HQ (!OGEhHVWSdvArJzumhm:matrix.org
) but the client disconnected after 180s (client timeout). This would be a good endpoint candidate to make cancelable (@cancellable
).While the
/context
request ran, it also degraded database performance for the wholeclient_reader
worker so we could limit the exposure by making it cancel on client disconnect. Plus we're doing work for nothing.In the same vein as #14290 for
/search
The text was updated successfully, but these errors were encountered: