Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Errors from unknown endpoints should issue CORS headers, to avoid confusing web client users/devs #1595

Closed
matrixbot opened this issue Sep 3, 2016 · 3 comments
Labels
z-p2 (Deprecated Label)

Comments

@matrixbot
Copy link
Member

Submitted by @​matthew:matrix.org

(Imported from https://matrix.org/jira/browse/SYN-763)

@matrixbot matrixbot changed the title ensure even errors from unknown endpoints issue cors headers, to avoid confusing web client devs in hunting cors problems (SYN-763) ensure even errors from unknown endpoints issue cors headers, to avoid confusing web client devs in hunting cors problems (https://github.com/matrix-org/synapse/issues/1595) Nov 7, 2016
@matrixbot matrixbot changed the title ensure even errors from unknown endpoints issue cors headers, to avoid confusing web client devs in hunting cors problems (https://github.com/matrix-org/synapse/issues/1595) ensure even errors from unknown endpoints issue cors headers, to avoid confusing web client devs in hunting cors problems (SYN-763) Nov 7, 2016
@ara4n ara4n changed the title ensure even errors from unknown endpoints issue cors headers, to avoid confusing web client devs in hunting cors problems (SYN-763) Errors from unknown endpoints should issue CORS headers, to avoid confusing web client users/devs Mar 24, 2019
@ara4n
Copy link
Member

ara4n commented Mar 24, 2019

This still causes massive confusion when people point their client at some endpoint which 404s, but the client turns the 404 into a CORS error which makes them hunt CORS problems rather than realise it's a 404.

@turt2live
Copy link
Member

Including ACAO / Access-Control-Allow-Origin

(added for keywords)

@richvdh
Copy link
Member

richvdh commented Aug 11, 2020

fixed by #7534

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
z-p2 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

4 participants