-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Own member event is duplicated in timeline when joining a room #9768
Comments
suspect this has the same cause as #1995 |
This happens in this bit of code, where synapse/synapse/handlers/sync.py Lines 523 to 529 in 2ca4e34
I'm not sure whether synapse/synapse/handlers/sync.py Lines 448 to 451 in 2ca4e34
Which only runs because Just in case I tested with lazy-loading disabled and still found the same issue. One hacky fix would just be to these things sets. |
I tried to reproduce this with a complement test. This failed. I can reproduce it on matrix.org, however. I suspect that this doesn't show up if you're running Synapse as a monolith. |
This was incorrect. I can reproduce it in complement, but only when I do a sync with a synapse/synapse/handlers/sync.py Lines 1517 to 1527 in a19d01c
|
From printf debugging, it looks like |
I've narrowed it down to here: synapse/synapse/handlers/sync.py Lines 603 to 604 in a19d01c
Unfamiliar with this. It looks like |
Oh god, I completely missed Andrew's comment #9768 (comment) |
I don't really understand the purpose of
I'm not sure how to merge |
The spec notes the following:
So I think that might explain what As for ordering, there's a warning infobox here which says
which is presumably the stream ordering. |
When accepting an invite to a new DM, I consistently (on matrix.org) see the last two events of the timeline being my own member event, duplicated. The request URL for this is https://matrix.org/_matrix/client/r0/sync?since=m1932336751~1.1932336915_757284961_312592_815559230_699804110_2214631_242549737_904922611_187106&timeout=30000&filter=2&_cacheBuster=1532609541718558
The text was updated successfully, but these errors were encountered: