This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Don't fail requests to unbind 3pids for non supporting ID servers #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ara4n
reviewed
Aug 8, 2018
synapse/handlers/identity.py
Outdated
| # The remote server probably doesn't support unbinding (yet) | ||
| defer.returnValue(False) | ||
| else: | ||
| raise SynapseError(502, "Failed to contact identity server") |
There was a problem hiding this comment.
shouldn't we include some info about the error we got from the IS?
There was a problem hiding this comment.
Yeah, possibly. Not sure what we'd want to copy? @richvdh did you have opinions about how this is meant to work?
There was a problem hiding this comment.
err, not really. It feels like it's probably not something a user is going to do much about, so I'm not sure there is much value in including it in the response.
What we probably should do is log the error.
Older identity servers may not support the unbind 3pid request, so we shouldn't fail the requests if we received one of 400/404/501. The request still fails if we receive e.g. 500 responses, allowing clients to retry requests on transient identity server errors that otherwise do support the API. Fixes #3661
erikjohnston
force-pushed
the
erikj/fixup_unbind
branch
from
b294d7f
to
360ba89
Compare
turt2live
added a commit
to turt2live/matrix-doc
that referenced
this pull request
Aug 27, 2018
Fixes matrix-org#985 Includes documentation for matrix-org/synapse#3667 Raises https://github.com/matrix-org/matrix-doc/issues/1566
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older identity servers may not support the unbind 3pid request, so we
shouldn't fail the requests if we received one of 400/404/501. The
request still fails if we receive e.g. 500 responses, allowing clients
to retry requests on transient identity server errors that otherwise do
support the API.