Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improved welcome page #4294

Merged
merged 5 commits into from
Dec 13, 2018
Merged

Improved welcome page #4294

merged 5 commits into from
Dec 13, 2018

Conversation

nadonomy
Copy link
Contributor

Overall improved the look, feel and content of the welcome page added in #4289. Specifically:

  • Added doctype/html language declarations etc
  • Added accessibility tags
  • Uses a system font stack which includes flavours of Linux
  • Added matrix logo (using in-line SVG)
  • Scales on mobile etc
  • Iterated on the content

Looks like:

screenshot 2018-12-13 at 13 28 04

synapse/static/index.html Outdated Show resolved Hide resolved
@ara4n
Copy link
Member

ara4n commented Dec 13, 2018

lgtm!

@ara4n ara4n requested a review from a team December 13, 2018 14:19
@ara4n
Copy link
Member

ara4n commented Dec 13, 2018

(n.b. for whoever merges this that it'll need to land on the right combo of branches rather than hotfixing 0.34-release)

@nadonomy
Copy link
Contributor Author

(n.b. for whoever merges this that it'll need to land on the right combo of branches rather than hotfixing 0.34-release)

Aha. I just PR'd to release-v0.34.0 as #4289 did.

If it's easiest for me to PR again lemme know where to point to.

@hawkowl hawkowl changed the base branch from release-v0.34.0 to develop December 13, 2018 14:32
@hawkowl
Copy link
Contributor

hawkowl commented Dec 13, 2018

I'll land it into develop and then cherry-pick it into the release branch.

@codecov-io
Copy link

codecov-io commented Dec 13, 2018

Codecov Report

Merging #4294 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4294      +/-   ##
===========================================
- Coverage     73.5%   73.49%   -0.01%     
===========================================
  Files          302      302              
  Lines        29895    29895              
  Branches      4893     4893              
===========================================
- Hits         21973    21971       -2     
- Misses        6485     6486       +1     
- Partials      1437     1438       +1
Impacted Files Coverage Δ
synapse/state/v1.py 90.69% <0%> (-1.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83826a...419bc5b. Read the comment docs.

@hawkowl hawkowl merged commit cef8ae2 into develop Dec 13, 2018
@richvdh
Copy link
Member

richvdh commented Dec 13, 2018

Aha. I just PR'd to release-v0.34.0 as #4289 did.

this was fine, for the record. I don't know why the base of the PR needed changing.

hawkowl pushed a commit that referenced this pull request Dec 13, 2018
* Improved static/index.html look, feel and content.

* Added accessibility tags to in-line SVG.

* Grammar.
richvdh added a commit that referenced this pull request Jan 8, 2019
Synapse 0.34.1rc1 (2019-01-08)
==============================

Features
--------

- Special-case a support user for use in verifying behaviour of a given server. The support user does not appear in user directory or monthly active user counts. ([\#4141](#4141), [\#4344](#4344))
- Support for serving .well-known files ([\#4262](#4262))
- Rework SAML2 authentication ([\#4265](#4265), [\#4267](#4267))
- SAML2 authentication: Initialise user display name from SAML2 data ([\#4272](#4272))
- Synapse can now have its conditional/extra dependencies installed by pip. This functionality can be used by using `pip install matrix-synapse[feature]`, where feature is a comma separated list with the possible values `email.enable_notifs`, `matrix-synapse-ldap3`, `postgres`, `resources.consent`, `saml2`, `url_preview`, and `test`. If you want to install all optional dependencies, you can use "all" instead. ([\#4298](#4298), [\#4325](#4325), [\#4327](#4327))
- Add routes for reading account data. ([\#4303](#4303))
- Add opt-in support for v2 rooms ([\#4307](#4307))
- Add a script to generate a clean config file ([\#4315](#4315))
- Return server data in /login response ([\#4319](#4319))

Bugfixes
--------

- Fix contains_url check to be consistent with other instances in code-base and check that value is an instance of string. ([\#3405](#3405))
- Fix CAS login when username is not valid in an MXID ([\#4264](#4264))
- Send CORS headers for /media/config ([\#4279](#4279))
- Add 'sandbox' to CSP for media reprository ([\#4284](#4284))
- Make the new landing page prettier. ([\#4294](#4294))
- Fix deleting E2E room keys when using old SQLite versions. ([\#4295](#4295))
- The metric synapse_admin_mau:current previously did not update when config.mau_stats_only was set to True ([\#4305](#4305))
- Fixed per-room account data filters ([\#4309](#4309))
- Fix indentation in default config ([\#4313](#4313))
- Fix synapse:latest docker upload ([\#4316](#4316))
- Fix test_metric.py compatibility with prometheus_client 0.5. Contributed by Maarten de Vries <maarten@de-vri.es>. ([\#4317](#4317))
- Avoid packaging _trial_temp directory in -py3 debian packages ([\#4326](#4326))
- Check jinja version for consent resource ([\#4327](#4327))
- fix NPE in /messages by checking if all events were filtered out ([\#4330](#4330))
- Fix `python -m synapse.config` on Python 3. ([\#4356](#4356))

Deprecations and Removals
-------------------------

- Remove the deprecated v1/register API on Python 2. It was never ported to Python 3. ([\#4334](#4334))

Internal Changes
----------------

- Getting URL previews of IP addresses no longer fails on Python 3. ([\#4215](#4215))
- drop undocumented dependency on dateutil ([\#4266](#4266))
- Update the example systemd config to use a virtualenv ([\#4273](#4273))
- Update link to kernel DCO guide ([\#4274](#4274))
- Make isort tox check print diff when it fails ([\#4283](#4283))
- Log room_id in Unknown room errors ([\#4297](#4297))
- Documentation improvements for coturn setup. Contributed by Krithin Sitaram. ([\#4333](#4333))
- Update pull request template to use absolute links ([\#4341](#4341))
- Update README to not lie about required restart when updating TLS certificates ([\#4343](#4343))
- Update debian packaging for compatibility with transitional package ([\#4349](#4349))
- Fix command hint to generate a config file when trying to start without a config file ([\#4353](#4353))
- Add better logging for unexpected errors while sending transactions ([\#4358](#4358))
@hawkowl hawkowl deleted the nadonomy/welcome-page branch May 21, 2019 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants