Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add a script to generate a clean config file #4315

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Dec 20, 2018

Ultimately I want to make this part of the debian and docker packaging process, to stop
the packaged configs getting out of sync.

Ultimately I want to make this part of the debian packaging process, to stop
the debian config getting out of sync.
@codecov-io
Copy link

Codecov Report

Merging #4315 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #4315      +/-   ##
==========================================
+ Coverage     73.5%   73.5%   +<.01%     
==========================================
  Files          302     302              
  Lines        29919   29923       +4     
  Branches      4900    4901       +1     
==========================================
+ Hits         21991   21996       +5     
+ Misses        6486    6484       -2     
- Partials      1442    1443       +1
Impacted Files Coverage Δ
synapse/config/homeserver.py 100% <ø> (+9.37%) ⬆️
synapse/config/registration.py 90.9% <100%> (+0.58%) ⬆️
synapse/config/database.py 75.86% <100%> (+0.86%) ⬆️
synapse/config/logger.py 63.44% <100%> (ø) ⬆️
synapse/config/key.py 67.64% <100%> (ø) ⬆️
synapse/config/repository.py 74.6% <100%> (+0.4%) ⬆️
synapse/config/_base.py 74.58% <100%> (-0.14%) ⬇️
synapse/config/metrics.py 100% <100%> (ø) ⬆️
synapse/config/server.py 64.1% <100%> (+0.3%) ⬆️
synapse/storage/util/id_generators.py 96.34% <0%> (-3.66%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc9cdba...59f93bb. Read the comment docs.

@richvdh richvdh requested a review from a team December 20, 2018 23:33
@richvdh
Copy link
Member Author

richvdh commented Dec 21, 2018

This is a precursor to fixing #1433, #1464, #2939, https://github.com/matrix-org/package-synapse-debian/issues/22, and possibly others...

Copy link
Contributor

@hawkowl hawkowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't have tests, but I'm assuming here that it's going to get run and scrutinised enough from the very nature of it.

@hawkowl hawkowl merged commit 9c2af7b into develop Dec 21, 2018
@hawkowl hawkowl deleted the rav/generate_config branch December 21, 2018 15:05
richvdh added a commit that referenced this pull request Jan 8, 2019
Synapse 0.34.1rc1 (2019-01-08)
==============================

Features
--------

- Special-case a support user for use in verifying behaviour of a given server. The support user does not appear in user directory or monthly active user counts. ([\#4141](#4141), [\#4344](#4344))
- Support for serving .well-known files ([\#4262](#4262))
- Rework SAML2 authentication ([\#4265](#4265), [\#4267](#4267))
- SAML2 authentication: Initialise user display name from SAML2 data ([\#4272](#4272))
- Synapse can now have its conditional/extra dependencies installed by pip. This functionality can be used by using `pip install matrix-synapse[feature]`, where feature is a comma separated list with the possible values `email.enable_notifs`, `matrix-synapse-ldap3`, `postgres`, `resources.consent`, `saml2`, `url_preview`, and `test`. If you want to install all optional dependencies, you can use "all" instead. ([\#4298](#4298), [\#4325](#4325), [\#4327](#4327))
- Add routes for reading account data. ([\#4303](#4303))
- Add opt-in support for v2 rooms ([\#4307](#4307))
- Add a script to generate a clean config file ([\#4315](#4315))
- Return server data in /login response ([\#4319](#4319))

Bugfixes
--------

- Fix contains_url check to be consistent with other instances in code-base and check that value is an instance of string. ([\#3405](#3405))
- Fix CAS login when username is not valid in an MXID ([\#4264](#4264))
- Send CORS headers for /media/config ([\#4279](#4279))
- Add 'sandbox' to CSP for media reprository ([\#4284](#4284))
- Make the new landing page prettier. ([\#4294](#4294))
- Fix deleting E2E room keys when using old SQLite versions. ([\#4295](#4295))
- The metric synapse_admin_mau:current previously did not update when config.mau_stats_only was set to True ([\#4305](#4305))
- Fixed per-room account data filters ([\#4309](#4309))
- Fix indentation in default config ([\#4313](#4313))
- Fix synapse:latest docker upload ([\#4316](#4316))
- Fix test_metric.py compatibility with prometheus_client 0.5. Contributed by Maarten de Vries <maarten@de-vri.es>. ([\#4317](#4317))
- Avoid packaging _trial_temp directory in -py3 debian packages ([\#4326](#4326))
- Check jinja version for consent resource ([\#4327](#4327))
- fix NPE in /messages by checking if all events were filtered out ([\#4330](#4330))
- Fix `python -m synapse.config` on Python 3. ([\#4356](#4356))

Deprecations and Removals
-------------------------

- Remove the deprecated v1/register API on Python 2. It was never ported to Python 3. ([\#4334](#4334))

Internal Changes
----------------

- Getting URL previews of IP addresses no longer fails on Python 3. ([\#4215](#4215))
- drop undocumented dependency on dateutil ([\#4266](#4266))
- Update the example systemd config to use a virtualenv ([\#4273](#4273))
- Update link to kernel DCO guide ([\#4274](#4274))
- Make isort tox check print diff when it fails ([\#4283](#4283))
- Log room_id in Unknown room errors ([\#4297](#4297))
- Documentation improvements for coturn setup. Contributed by Krithin Sitaram. ([\#4333](#4333))
- Update pull request template to use absolute links ([\#4341](#4341))
- Update README to not lie about required restart when updating TLS certificates ([\#4343](#4343))
- Update debian packaging for compatibility with transitional package ([\#4349](#4349))
- Fix command hint to generate a config file when trying to start without a config file ([\#4353](#4353))
- Add better logging for unexpected errors while sending transactions ([\#4358](#4358))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants