-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Improved delegation doc (adding .well-known info) #4781
Conversation
af9382c
to
8907648
Compare
Signed-off-by: Valentin Lab <valentin.lab@kalysto.org>
8907648
to
ec65407
Compare
It definitively needs technical overview, as I'm very new to |
Tracking here #4832 |
Improved federation configuration docs. Specifically detailing .well-known and SRV based delegation methods. Inspiration Valentin Lab <valentin.lab@kalysto.org> for #4781
Improved federation configuration docs. Specifically detailing .well-known and SRV based delegation methods. Inspiration Valentin Lab <valentin.lab@kalysto.org> for #4781
Thanks ! I noticed you nearly completely removed my (perhaps too heavy) warnings about DNS SRV method not actually delivering a complete delegation as .well-known method would do. This is a keypoint that is quite unexpected and completely invalidates DNS SRV as a working delegation solution in a common scenario : people using virtualhosts, and using both domain name (the delegatee and the delegated) in 2 different virtualhosts that have to answer 2 different SSL ids. In the pushed documentation, you still sell both delegation method as equivalent, which they are clearly not functionally speaking. It appeared to me primordial to add this info in the introduction so as the people could safely choose the solution they wanted to use. To be honest, the time I lost on that particular point was what pushed me trying to contribute here on a better doc, as I really felt misguided. I'm just trying here to share what seemed important for me in my contribution, I'm very happy that the documentation moved forward anyway. I noticed your careful attention for reviewing my flawed contribution and make it better. And I wish I had more time to bring up this point at the right moment. Feel free to ignore my point if you feel so. |
@vaab: the point is that the two delegation methods offer different features; it's simply not true to say that .well-known is a "complete" delegation and that SRV is somehow incomplete. Arguably .well-known is incomplete because it doesn't offer round-robin and failover support. Neil's rewrite fairly clearly spells out the requirements for the TLS certificate: here "This method requires the target server to provide a valid TLS certificate for the original |
Just a suggestion of improvement of the doc provided in the README... that's by no mean a perfect solution and am happy if it is not integrated for some reason, but at least if this kind of doc could have been there in the first place, I would definitively saved one days of battling my way through the numerous incomplete documentations and guide.
It this addition seems to help, I'll add the changelog file gladly for inclusion.
Pull Request Checklist