This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use event streams to calculate presence #4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/fix_presence
branch
from
0a63923
to
b02b719
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4942 +/- ##
===========================================
+ Coverage 60.44% 60.52% +0.07%
===========================================
Files 331 328 -3
Lines 34100 34173 +73
Branches 5627 5647 +20
===========================================
+ Hits 20612 20683 +71
+ Misses 12017 12011 -6
- Partials 1471 1479 +8 |
|
I'm still figuring out quite how to test this fixes the bug, but at least we have sytests to check that the correct behaviour happens |
Primarily this fixes a bug in the handling of remote users joining a room where the server sent out the presence for all local users in the room to all servers in the room. We also change to using the state delta stream, rather than the distributor, as it will make it easier to split processing out of the master process (as well as being more flexible). Finally, when sending presence states to newly joined servers we filter out old presence states to reduce the number sent. Initially we filter out states that are offline and have a last active more than a week ago, though this can be changed down the line. Fixes #3962
erikjohnston
force-pushed
the
erikj/fix_presence
branch
from
f1be5cb
to
d5a5d1c
Compare
richvdh
reviewed
Mar 28, 2019
| @@ -220,6 +220,15 @@ def __init__(self, hs): | |||
| LaterGauge("synapse_handlers_presence_wheel_timer_size", "", [], | |||
| lambda: len(self.wheel_timer)) | |||
|
|
|||
| # Used to handle sending of presence to newly joined users/servers | |||
| if hs.config.use_presence: | |||
| self.notifier.add_replication_callback(self.notify_new_event) | |||
There was a problem hiding this comment.
I'd love it if the stuff in the notifier could be renamed to be less about "replication", since we seem to be using it for things which aren't replication. Guess we can leave that for another time, though.
erikjohnston
force-pushed
the
erikj/fix_presence
branch
from
50a9e39
to
4e5f0f7
Compare
erikjohnston
added a commit
that referenced
this pull request
Apr 10, 2019
Entries in current state can be "deleted", so we need to handle the case where the new event_id is None. Introduced in #4942.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily this fixes a bug in the handling of remote users joining a
room where the server sent out the presence for all local users in the
room to all servers in the room.
We also change to using the state delta stream, rather than the
distributor, as it will make it easier to split processing out of the
master process (as well as being more flexible).
Finally, when sending presence states to newly joined servers we filter
out old presence states to reduce the number sent. Initially we filter
out states that are offline and have a last active more than a week ago,
though this can be changed down the line.
Fixes #3962
Note that there a few
TODOitems, but I think they can be solved separately. Certainly I think what we have now is strictly better than what was there before.