Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Cross-signing [2/4] - upload/download keys #5769
OK, I think I know what's up with the unit test. When I fetch the cross-signing key, I order by timestamp and pick the first one. But the timestamp only has 1-second resolution, and the unit tests run too fast, so the two keys get stored with the timestamp. So when it fetches the keys, it basically picks one at random. (I guess the fact that it's never happened on my laptop means that my laptop is slow enough that the keys don't have the same timestamp. Or it's just extremely lucky.)
So, what's the best way of ensuring that the key that was last stored is the one that gets selected? Normally, I would use an
@@ Coverage Diff @@ ## uhoreg/e2e_cross-signing_merged #5769 +/- ## ================================================================== Coverage ? 63.45% ================================================================== Files ? 331 Lines ? 36668 Branches ? 6068 ================================================================== Hits ? 23267 Misses ? 11729 Partials ? 1672
Switching to using stream ID generator seems to have fixed the tests.
The sytest failure I think is not-my-fault, since it's only failing in the worker sytest, and the sytest that's running against it isn't even calling any cross-signing functionality, but it's hard to tell because it doesn't seem to be copying the sytest artifacts properly.
Python will return a tuple whether there are parentheses around the returned values or not. I'm just sick of my editor complaining about this all over the place :)
* fix thumbnail storage location Signed-off-by: Lorenz Steinert <firstname.lastname@example.org> * Add changelog file. Signed-off-by: Lorenz Steinert <email@example.com> * Update Changelog Signed-off-by: Lorenz Steinert <firstname.lastname@example.org>
These methods were part of the v1 C/S API. Remove them as they are no longer used by any code paths.
Remove all the "double return" statements which were a result of us removing all the instances of ``` defer.returnValue(...) return ``` statements when we switched to python3 fully.
* Ensure the list media admin API is always available This API is required for some external media repo implementations to operate (mostly for doing quarantine operations on a room). * changelog
Removes the `bind_email` and `bind_msisdn` parameters from the `/register` C/S API endpoint as per [MSC2140: Terms of Service for ISes and IMs](https://github.com/matrix-org/matrix-doc/pull/2140/files#diff-c03a26de5ac40fb532de19cb7fc2aaf7R107).