Skip to content

Conversation

@AlanCristhian
Copy link

@MattDMo
Copy link
Owner

MattDMo commented May 26, 2015

Thanks for the PR, I actually haven't gotten around to reviewing 3.5 yet. Have you tested this with decorators to ensure the @ isn't scoped keyword.operator.arithmetic.python?

@MattDMo MattDMo self-assigned this May 26, 2015
@MattDMo
Copy link
Owner

MattDMo commented May 26, 2015

Also, can you add @= to keyword.operator.assignment.augmented.python? It's just above keyword.operator.arithmetic.python. Thanks.

@AlanCristhian
Copy link
Author

I broke decorators, I will try to fix them. And yes, I can add the inplace operator.

Don't worry so much about this PR, we have time. Python 3.5 is planned for September.

@MattDMo
Copy link
Owner

MattDMo commented May 27, 2015

Yeah, I know it's not due to be officially released until this fall, but it shows up on python.org on the downloads page (for example here) and the first beta is out, so it'll be getting more exposure. I'd like to stay ahead of the game if we can.

@MattDMo
Copy link
Owner

MattDMo commented May 27, 2015

From PEP-0465:

Currently, the only legal use of the @ token in Python code is at statement beginning in decorators. The new operators are both infix; the one place they can never occur is at statement beginning. Therefore, no existing code will be broken by the addition of these operators, and there is no possible parsing ambiguity between decorator-@ and the new operators.

This can help with designing the regex to differentiate between the @ infix operator and the beginning of a decorator. @= doesn't have this problem, as both characters are required for it to be valid, and are not present in decorators.

…keyword.control.flow.python' to 'storage.modifier.declaration.python'
@1st1
Copy link
Contributor

1st1 commented Aug 7, 2015

When are you guys going to merge this in master?

@AlanCristhian
Copy link
Author

I've been using the patched version since my last pull request and I not found any problem. So I think that is ready to merge.

@1st1
Copy link
Contributor

1st1 commented Aug 10, 2015

@MattDMo ?

@MattDMo
Copy link
Owner

MattDMo commented Aug 11, 2015

These changes have been added to the unicode branch. As soon as I'm done testing the changes there, it will be merged back into master and a new version released.

@1st1
Copy link
Contributor

1st1 commented Aug 11, 2015

BTW, we also need to highlight StopAsyncIteration and RecursionError – new built-ins in Python 3.5

@1st1
Copy link
Contributor

1st1 commented Aug 14, 2015

See also PR #44

@MattDMo MattDMo added this to the 2.0 milestone Sep 10, 2015
@MattDMo MattDMo closed this Sep 10, 2015
infininight pushed a commit to infininight/python.tmbundle that referenced this pull request Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants