Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(en): Add pruning health checks and rework pruning config #1790

Merged
merged 22 commits into from
Apr 30, 2024
Merged

feat(en): Add pruning health checks and rework pruning config #1790

merged 22 commits into from
Apr 30, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Apr 25, 2024 •
edited
Loading

What ❔

  • Adds health checks for pruning tasks.
  • Reworks the metadata calculator health check so that it's up-to-date in case of pruning.
  • Extends the snapshot recovery IT so that it tests pruning as well.

Why ❔

  • Pruning is an important aspect to test, and IT would allow to test it in (somewhat) realistic conditions.
  • Other changes are required for the integration test, but they also make sense in general.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

feat(db): Implement weak references to RocksDB
test(en): Add integration test for pruning

slowli
slowli commented Apr 25, 2024
View reviewed changes
core/bin/external_node/src/config/mod.rs Outdated Show resolved Hide resolved
core/lib/storage/src/db.rs Outdated Show resolved Hide resolved
@slowli slowli marked this pull request as ready for review April 25, 2024 14:52
RomanBrodetski
RomanBrodetski previously approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@RomanBrodetski RomanBrodetski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

core/bin/external_node/src/config/mod.rs Outdated Show resolved Hide resolved
core/lib/zksync_core/src/db_pruner/metrics.rs Show resolved Hide resolved
core/lib/zksync_core/src/db_pruner/mod.rs Show resolved Hide resolved
@slowli slowli requested a review from popzxc April 30, 2024 08:09
@slowli slowli added this pull request to the merge queue Apr 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 30, 2024
@slowli slowli added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit e0d4daa Apr 30, 2024
36 checks passed
@slowli slowli deleted the aov-pla-878-add-integration-test-for-pruning branch April 30, 2024 15:55
@zksync-era-bot zksync-era-bot mentioned this pull request Apr 30, 2024
Merged
RomanBrodetski pushed a commit that referenced this pull request May 8, 2024
@zksync-era-bot @perekopskiy
chore(main): release core 24.1.0 (#1836)
4df5b7f 
🤖 I have created a release *beep* *boop*
---


##
[24.1.0](core-v24.0.0...core-v24.1.0)
(2024-05-08)


### Features

* add `sendRawTransactionWithDetailedOutput` API
([#1806](#1806))
([6a30a31](6a30a31))
* add getGasPerPubdataByte endpoint
([#1778](#1778))
([d62dd08](d62dd08))
* **config:** Wrap sensitive urls
([#1828](#1828))
([c8ee740](c8ee740))
* **db:** Implement weak references to RocksDB
([e0d4daa](e0d4daa))
* **en:** Add pruning health checks and rework pruning config
([#1790](#1790))
([e0d4daa](e0d4daa))
* Extract proof_data_handler into separate crate
([#1677](#1677))
([f4facee](f4facee))
* Extract several crates from zksync_core
([#1859](#1859))
([7dcf796](7dcf796))
* **node:** Extract genesis into separate crate
([#1797](#1797))
([a8c4599](a8c4599))
* **Prover CLI:** `status batch` command
([#1638](#1638))
([3fd6d65](3fd6d65))
* prover components versioning
([#1660](#1660))
([29a4ffc](29a4ffc))
* Update provers current version
([#1872](#1872))
([bb5f129](bb5f129))


### Bug Fixes

* **basic_types:** bincode deserialization for `L2ChainId`
([#1835](#1835))
([fde85f4](fde85f4))
* **contract-verifier:** YUL system-mode verification
([#1863](#1863))
([5aa7d41](5aa7d41))
* **loadtest:** Do not initiate transactions with 0 amount
([#1847](#1847))
([1bbe108](1bbe108))


### Performance Improvements

* **db:** Fine-tune state keeper cache performance / RAM usage
([#1804](#1804))
([82bf40e](82bf40e))
* **state-keeper:** Improve `FilterWrittenSlots` l1 batch seal stage
([#1854](#1854))
([4cf235f](4cf235f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: perekopskiy <mikeson.dp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

@RomanBrodetski RomanBrodetski RomanBrodetski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slowli @RomanBrodetski @popzxc