feat: add sendRawTransactionWithDetailedOutput API
#1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischasny
changed the title
montekki
reviewed
Apr 29, 2024
montekki
reviewed
Apr 29, 2024
Co-authored-by: Fedor Sakharov <fedor.sakharov@gmail.com>
Co-authored-by: Fedor Sakharov <fedor.sakharov@gmail.com>
montekki
previously approved these changes
Apr 29, 2024
core/lib/zksync_core/src/api_server/web3/backend_jsonrpsee/namespaces/zks.rs
Outdated
Show resolved
Hide resolved
ischasny
changed the title
sendRawTransactionWithDetailedOutput API
RomanBrodetski
previously approved these changes
Apr 29, 2024
RomanBrodetski
previously approved these changes
Apr 29, 2024
auto-merge was automatically disabled
April 30, 2024 09:46
Merge queue setting changed
RomanBrodetski
approved these changes
Apr 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
RomanBrodetski
pushed a commit
that referenced
this pull request
May 8, 2024
🤖 I have created a release *beep* *boop* --- ## [24.1.0](core-v24.0.0...core-v24.1.0) (2024-05-08) ### Features * add `sendRawTransactionWithDetailedOutput` API ([#1806](#1806)) ([6a30a31](6a30a31)) * add getGasPerPubdataByte endpoint ([#1778](#1778)) ([d62dd08](d62dd08)) * **config:** Wrap sensitive urls ([#1828](#1828)) ([c8ee740](c8ee740)) * **db:** Implement weak references to RocksDB ([e0d4daa](e0d4daa)) * **en:** Add pruning health checks and rework pruning config ([#1790](#1790)) ([e0d4daa](e0d4daa)) * Extract proof_data_handler into separate crate ([#1677](#1677)) ([f4facee](f4facee)) * Extract several crates from zksync_core ([#1859](#1859)) ([7dcf796](7dcf796)) * **node:** Extract genesis into separate crate ([#1797](#1797)) ([a8c4599](a8c4599)) * **Prover CLI:** `status batch` command ([#1638](#1638)) ([3fd6d65](3fd6d65)) * prover components versioning ([#1660](#1660)) ([29a4ffc](29a4ffc)) * Update provers current version ([#1872](#1872)) ([bb5f129](bb5f129)) ### Bug Fixes * **basic_types:** bincode deserialization for `L2ChainId` ([#1835](#1835)) ([fde85f4](fde85f4)) * **contract-verifier:** YUL system-mode verification ([#1863](#1863)) ([5aa7d41](5aa7d41)) * **loadtest:** Do not initiate transactions with 0 amount ([#1847](#1847)) ([1bbe108](1bbe108)) ### Performance Improvements * **db:** Fine-tune state keeper cache performance / RAM usage ([#1804](#1804)) ([82bf40e](82bf40e)) * **state-keeper:** Improve `FilterWrittenSlots` l1 batch seal stage ([#1854](#1854)) ([4cf235f](4cf235f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: perekopskiy <mikeson.dp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
zks_sendRawTransactionWithDetailedOutputAPI that instantly returns storage logs and events (like if the transaction would have already been applied) alongside the transaction hash. The API is behaviourally analogous toeth_sendRawTransactionbut with some extra data returned from it.This feature will allow consumer apps to apply "optimistic" events in their applications instantly without having to wait for zkSync block confirmation time.
It’s expected that optimistic logs of two uncommitted transaction that modify the same state will not have causal relationships between each other.