go1.8: support for additional features

[kardianos]

Many new important features will land in go1.8. Please see document:
https://docs.google.com/document/d/1F778e7ZSNiSmbju3jsEWzShcb8lIO4kDyfKDNm4PNd8/edit?usp=sharing for the full list.

Because these features are new we want drivers to implement them before they are released. Ideally they should be implemented by 2016-12-12 to allow for any driver provided feedback from implementation if necessary.

[mattn]

Look into it in later. But context.Context is used for the new feature. How do you think backward compatibility?

[kardianos]

You make a valid point. I'm looking into it now.

[kardianos]

Use "golang.org/x/net/context" and arrange your files like the sample in the google docs in the section "Supporting pre-go1.8 side by side."

[mattn]

Okay, at the first, I'll add code without context features. ex ColumnTypeXXX. Thanks.

[mattn]

I'm implementing HasNextResultSet, I have one question. When the several queries in a string, driver should send all of queries? if the part of query was wrong, following queries should not be executed?

[kardianos]

My understand with sqlite (which could be wrong) is that it will execute
multiple sql statements in a single prepared batch so long as they are
separated by semicolon. However from initial looking it doesn't seem like
the sqlite engine supports multiple result sets. This is distinct from say
MS SQL Server or My SQL which will return from the server multiple result
sets from just a single query.

So I think you should just send any query string to sqlite like normally.
It just may not support NextResultSet, but unsure.

On Fri, Nov 4, 2016 at 12:19 AM mattn notifications@github.com wrote:

I'm implementing HasNextResultSet, I have one question. When the several
queries in a string, driver should send all of queries? if the part of
query was wrong, following queries should not be executed?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#346 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAuFse9y1lXotZjIpdMhJMqfg2VEbI3jks5q6tyYgaJpZM4KmTnu
.

[mattn]

Merged into master branch. #348

Thanks.

[mattn]

However, I have some projects to do same. :-(

[mattn]

Ah, I miss IsolationContext.

[mattn]

SQLite3 doesn't support transaction isolate level. It only support single lock transaction per database. So I don't support IsolationContext for go-sqlite3.

@kardianos thanks your advices.