Skip to content

Conversation

pwaller
Copy link
Contributor

@pwaller pwaller commented Aug 11, 2014

This commit simply tries to parse things as a time if the decltype is specified as a "date".

I found some databases which aren't correctly interpreted if this isn't checked as well.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ff0960b on pwaller:decltype-date into 1704ea5 on mattn:master.

@mattn
Copy link
Owner

mattn commented Aug 11, 2014

@pwaller
Copy link
Contributor Author

pwaller commented Aug 11, 2014

@mattn I don't know about that one, I haven't come across it in the wild. Do you know what the correct conversion is if the field type is "date" but the underlying storage is an "int" ?

@mattn
Copy link
Owner

mattn commented Aug 12, 2014

This is convertion for date to unix epoc.

@pwaller
Copy link
Contributor Author

pwaller commented Sep 2, 2014

Done, sorry for the delay, was on holiday - will respond more quickly again now.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.13%) when pulling 764e046 on pwaller:decltype-date into 1704ea5 on mattn:master.

@mattn mattn merged commit 764e046 into mattn:master Sep 3, 2014
@mattn
Copy link
Owner

mattn commented Sep 3, 2014

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants