Skip to content

Conversation

elgris
Copy link

@elgris elgris commented Jun 26, 2015

Supports #213.

Please consider this PR as a major change because it updates SQLite bindings to version 3.8.10.2.
The amalgamation source code was built with SQLITE_ENABLE_UPDATE_DELETE_LIMIT flag enabled.

@mattn
Copy link
Owner

mattn commented Jun 26, 2015

Please don't upgrade sqlite3.c. go has problem about this.

golang/go#9356

@elgris
Copy link
Author

elgris commented Jun 26, 2015

Hm... Is it because of version 3.8.10.2 or there is another reason and current squirrel-binding.c is highly customized?Is it ok to rebuild sqlite.c v3.8.5 (as it is in master right now), but with SQLITE_ENABLE_UPDATE_DELETE_LIMIT enabled?

@mattn
Copy link
Owner

mattn commented Jun 26, 2015

Yes, please.

@elgris
Copy link
Author

elgris commented Jun 26, 2015

Ok, I rolled back bindings to v3.8.5. Could you please check failing scenario on Windows?

@mattn
Copy link
Owner

mattn commented Jun 26, 2015

Hmm, totally diff seems deleted/appended into sqlite3-binding.c. I'm thinking we can't touch sqlite3-binding.c for now.

@elgris
Copy link
Author

elgris commented Jun 26, 2015

Actually, this is rebuilt version of sqlite3-binding.c. I built it from the sources of version 3.8.5 (like it was before), just added SQLITE_ENABLE_UPDATE_DELETE_LIMIT flag at configure and build steps. Generally, this is the same code, just with extra function added

@ghost
Copy link

ghost commented Nov 14, 2015

@mattn any word on this? I could really use it.

@mattn
Copy link
Owner

mattn commented Nov 15, 2015

https://www.sqlite.org/compile.html

If this option is defined, then it must also be defined when using the 'lemon' tool to generate a parse.c file. Because of this, this option may only be used when the library is built from source, not from the amalgamation or from the collection of pre-packaged C files provided for non-Unix like platforms on the website.

Is this your expected?

@ghost
Copy link

ghost commented Nov 15, 2015

@mattn yes

@mattn
Copy link
Owner

mattn commented Nov 21, 2017

Could you please rebase master?

@gjrtimmer
Copy link
Collaborator

Should be closed because of #564

@mattn
Copy link
Owner

mattn commented May 24, 2018

note that not mean that this enabling delete limit also when using libsqlite3 on system always.

@mattn mattn closed this May 24, 2018
@EmpireJones EmpireJones mentioned this pull request Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants