Skip to content

Conversation

brokensandals
Copy link

This would address #177

@siscia
Copy link

siscia commented Sep 4, 2016

@mattn : It is really a pity that that this PR is not been considered much.

@mattn
Copy link
Owner

mattn commented Sep 5, 2016

Seems good to me. Could you please rebase master?

@siscia
Copy link

siscia commented Sep 5, 2016

@mattn , @brokensandals I may do it, but it will take me a while, I am a little busy and I don't know the basecode so well.

@brokensandals feel free to jump in whenever you want.

@brokensandals brokensandals force-pushed the update-and-transaction-hooks branch from 79d29a8 to 2136168 Compare September 11, 2016 01:09
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 68.092% when pulling 2136168 on brokensandals:update-and-transaction-hooks into 3fb7a0e on mattn:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 68.092% when pulling 2136168 on brokensandals:update-and-transaction-hooks into 3fb7a0e on mattn:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 68.092% when pulling 2136168 on brokensandals:update-and-transaction-hooks into 3fb7a0e on mattn:master.

@brokensandals
Copy link
Author

@mattn thanks for taking a look. I no longer have a use case for this functionality and won't be offended if you choose not to merge it, but I went ahead and rebased since it sounds like it may be useful to others.

@mattn mattn closed this Sep 12, 2016
@Jason-Abbott
Copy link
Contributor

@mattn Any chance of reconsidering this for merge? I'd be happy to contribute with testing, rebasing, whatever, though it looks like the original PR was pretty complete.

I was planning to do some testing with these hooks before I discovered they aren't implemented here.

@mattn
Copy link
Owner

mattn commented Jul 3, 2017

Sorry. I wonder why I closed this. Could you please rebase master?

@Jason-Abbott
Copy link
Contributor

I don't have access to @brokensandals branch to rebase but I made my own fork that copies and credits his changes. I'll rebase and PR that.

@Jason-Abbott
Copy link
Contributor

@mattn I made #434 since I don't have access to rebase the branch for this PR.

@mattn
Copy link
Owner

mattn commented Aug 30, 2017

closed by #434

@mattn mattn closed this Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants