-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add functions to register update, commit, and rollback hooks. #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions to register update, commit, and rollback hooks. #271
Conversation
@mattn : It is really a pity that that this PR is not been considered much. |
Seems good to me. Could you please rebase master? |
@mattn , @brokensandals I may do it, but it will take me a while, I am a little busy and I don't know the basecode so well. @brokensandals feel free to jump in whenever you want. |
79d29a8
to
2136168
Compare
2 similar comments
@mattn thanks for taking a look. I no longer have a use case for this functionality and won't be offended if you choose not to merge it, but I went ahead and rebased since it sounds like it may be useful to others. |
@mattn Any chance of reconsidering this for merge? I'd be happy to contribute with testing, rebasing, whatever, though it looks like the original PR was pretty complete. I was planning to do some testing with these hooks before I discovered they aren't implemented here. |
Sorry. I wonder why I closed this. Could you please rebase master? |
I don't have access to @brokensandals branch to rebase but I made my own fork that copies and credits his changes. I'll rebase and PR that. |
closed by #434 |
This would address #177