Skip to content

Conversation

a-p-
Copy link
Contributor

@a-p- a-p- commented Sep 23, 2016

This adds some limited testing of the error result returned by Backup().

An error result is intentionally triggered by using the same connection for the source and destination.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.03%) to 62.274% when pulling 0e686ca on a-p-:test-backup-error into 3fb7a0e on mattn:master.

1 similar comment
@coveralls
Copy link

coveralls commented Sep 23, 2016

Coverage Status

Coverage decreased (-5.03%) to 62.274% when pulling 0e686ca on a-p-:test-backup-error into 3fb7a0e on mattn:master.

@a-p-
Copy link
Contributor Author

a-p- commented Sep 23, 2016

The decrease in coverage is unexpected, since this pull request adds additional testing...

Something might be wrong with Coveralls?

For this pull request's build in Coveralls (378), the "ALL" tab near the bottom shows 8 files, instead of 6 for previous recent builds (like build 377). These files are now listed:

  • tool/upgrade.go
  • sqlite3_test/sqltest.go

Also, the "CHANGED" and "COVERAGE CHANGED" tabs both show 4 affected files, although 3 of them are listed as unchanged...

backup.go's coverage is showing as increased, as expected, however.

@mattn mattn merged commit 4b0af85 into mattn:master Sep 27, 2016
@mattn
Copy link
Owner

mattn commented Sep 27, 2016

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants