Skip to content

Conversation

fancycode
Copy link
Contributor

This should hopefully fix the remaining of #352.

@fancycode
Copy link
Contributor Author

Please wait for Travis to finish before merging this to see if anything else needs to be changed.

@coveralls
Copy link

coveralls commented Nov 8, 2016

Coverage Status

Coverage remained the same at 62.818% when pulling 2a8d6d2 on fancycode:fix_trace into 14e5ed1 on mattn:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.818% when pulling 2a8d6d2 on fancycode:fix_trace into 14e5ed1 on mattn:master.

@coveralls
Copy link

coveralls commented Nov 8, 2016

Coverage Status

Coverage remained the same at 62.818% when pulling b11c615 on fancycode:fix_trace into d1009b4 on mattn:master.

@fancycode
Copy link
Contributor Author

@mattn Building now works for all cases but libsqlite3 trace:

could not determine kind of name for C.SQLITE_DETERMINISTIC
could not determine kind of name for C.SQLITE_TRACE_CLOSE
could not determine kind of name for C.SQLITE_TRACE_PROFILE
could not determine kind of name for C.SQLITE_TRACE_ROW
could not determine kind of name for C.SQLITE_TRACE_STMT
could not determine kind of name for C.sqlite3_expanded_sql
could not determine kind of name for C.sqlite3_trace_v2

Is this supposed to work or should I remove it from the Travis build matrix? If it is unsupported it would be better to not build the tracing code if libsqlite3 is defined (even it also trace is defined).

@mattn
Copy link
Owner

mattn commented Nov 8, 2016

Thank you. But, I modified master branch already because it will need more fixes.

https://travis-ci.org/mattn/go-sqlite3/builds/174141111

@mattn mattn closed this Nov 8, 2016
@fancycode
Copy link
Contributor Author

You should at least merge / cherry-pick this commit:
b11c615

Otherwise the combination of libsqlite3 trace is not tested correctly in Travis (only sets libsqlite3). Also I rebased to your latest changes on master...

@mattn
Copy link
Owner

mattn commented Nov 8, 2016

@mattn
Copy link
Owner

mattn commented Nov 8, 2016

libsqlite3 on travis is too old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants