enable common cflags for perf #422
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoiron
commented
Jun 1, 2017
jmoiron
commented
- enable HAVE_USLEEP
- enable intrinsics
* enable [HAVE_USLEEP](http://beets.io/blog/sqlite-nightmare.html) * enable intrinsics
|
there are other open PRs for this, presumably you don't want the intrinsics thing here, but HAVE_USLEEP is a common issue |
2 similar comments
|
Seems removing SQLITE_DISABLE_INTRINSIC, It fixes this too? |
|
@mattn I removed it only for perf reason but if it fixes something too that's good! The USLEEP thing is very difficult to find, tests randomly/suspiciously take 1.001s |
4 similar comments
|
Edit It seems that the computer I was testing this on had a disk that was having some issues and causing most of this latency. Back to the drawing board :) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.