Skip to content
This repository was archived by the owner on Apr 21, 2018. It is now read-only.

Add support for the clang compiler #14

Closed
wants to merge 1 commit into from
Closed

Add support for the clang compiler #14

wants to merge 1 commit into from

Conversation

toonetown
Copy link
Contributor

This came from the diff at http://jogamp.org/git/?p=ant-cpptasks.git;a=commitdiff;h=2cdd1070056c0f7e9dc7f40de19c2bfdfef0432a;hp=2603158cb1a0ff29f5a23de4c0ba2ce759f574cf - it is fairly straightforward, and adds support for specifying either clang or clang++ as a compiler

@buildhive
Copy link

NAR plugin for Maven » cpptasks-parallel #7 SUCCESS
This pull request looks good
(what's this?)

@ctrueden
Copy link
Contributor

Haha, I didn't even see this PR before filing mine (#15)! Obviously, this work is ultimately what is necessary for clang to work as expected. I'll test this PR against the nar-maven-plugin ITs and see whether it addresses the it0002 and it0005...

@ctrueden
Copy link
Contributor

Unfortunately, on its own, this change does not fix it0002 and it0005. Haven't had time to investigate yet...

@ctrueden ctrueden mentioned this pull request Nov 21, 2013
* <td>clang</td>
* <td>clang / llvm C compiler</td>
* </tr>
* <tr>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant to move these lines below the g++ section, i.e. just before the clang++ section. If you agree, I can move them...

@dscho
Copy link
Member

dscho commented Nov 23, 2013

DEV@cloud: Can one of the admins verify this patch?

@dscho
Copy link
Member

dscho commented Nov 23, 2013

this is ok to test

@dscho
Copy link
Member

dscho commented Nov 25, 2013

Please see https://github.com/maven-nar/cpptasks-parallel/compare/clang and tell me whether that is okay...

@ctrueden
Copy link
Contributor

Closing in favor of PR #16, which is a rebased combination of this PR and #15.

@ctrueden ctrueden closed this Nov 26, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants