Top level config option to log command-line for eclipse to parse... default off #5
Conversation
|
NAR plugin for Maven » cpptasks-parallel #14 SUCCESS |
|
In principle, I like the idea of the topic branch, but I'd rather have it cleaned up a little. After all, the ultimate goal with cpptasks-parallel should be to get it into cpptasks, not to be stuck with an eternal fork. So we should focus not so much on what NAR requires, but more on a change of general utility that also happens to address our problem. |
|
DEV@cloud: Can one of the admins verify this patch? |
|
OK, I think I:ve been to quick in this since you are getting ready for release. I don't know git well enough to know if I can do something about bad commit messages... |
|
@TotallyPro with Git, it is easy to do something about bad commit messages: rewrite history with git-rebase. Simply start an interactive rebase (the original name of that command was Looking forward to your changes! |
|
NAR plugin for Maven » cpptasks-parallel #16 SUCCESS |
| @@ -1052,7 +1059,7 @@ public boolean accept(File file) { | |||
| .print("\r "); | |||
| System.err.print("\r"); | |||
| System.err.flush(); | |||
| log(Integer.toString(rebuildCount) + " files were compiled."); | |||
| log(Integer.toString(rebuildCount) + " files were compiled.",Project.MSG_VERBOSE); | |||
There was a problem hiding this comment.
There where many logs not stating which loglevel to use. When used in nar-maven-plugin it looked strange that these logs never showed when they should (MSG_WARN or MSG_ERROR cases)
There was a problem hiding this comment.
I agree. But it is a functionally different change from the one described in the commit message, and should therefore be in its own commit. See http://git-scm.com/book/en/Git-Tools-Rewriting-History#Splitting-a-Commit.
In certain use cases, it is desirable to be able to change the log level at which cpptasks-parallel logs the command lines called for external commands, e.g. when the command lines are meant to be parsed by, say, Eclipse's CDT to make nicer logs.
|
NAR plugin for Maven » cpptasks-parallel #17 SUCCESS |
Top level config option to log command-line for eclipse to parse... default off
NOTE! This is half the change, will send another request for nar-maven-plugin based on whats already in my fork...
I found myself running by builds with -X in eclipse, just to get the CDT behavior I have come to expect. As long as the extensive logging didn't overrun the Console buffers I got my code-completion and navigations (F3) back.
However I decided to attempt to make nar-maven.plugin log the command-lines with less fuzz.
After a brief interaction with Johannes Schindelin I choose to make a top-level config option commandLog
that is default false. If set to true the command-lines only are lifted from DEBUG-level to INFO.
I have been using this for a couple of hours and it works like a charm and eclipse CDT is delivering again.
I hope to get this into mainstream since it is a quite simple addition and very usefull to anyone using CDT.