Skip to content

Handle repeated non-primitive types in translate_from_rpc #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2020
Merged

Handle repeated non-primitive types in translate_from_rpc #206

merged 1 commit into from
Jun 3, 2020

Conversation

JonasVautherin
Copy link
Collaborator

Fixes #201.

@petergerten: would you mind testing this? On my end I can now load your test.plan.

@JonasVautherin JonasVautherin requested a review from julianoes June 3, 2020 14:36
julianoes
julianoes approved these changes Jun 3, 2020
View reviewed changes
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@petergerten
Copy link
Contributor

@JonasVautherin all good - works perfect! Thanks :-)

@julianoes julianoes merged commit 0265233 into master Jun 3, 2020
@julianoes julianoes deleted the fix-201 branch June 3, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianoes julianoes julianoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import_qgroundcontrol_mission() does not work (AttributeError: 'RepeatedCompositeFieldContainer' object has no attribute 'latitude_deg')
3 participants
@JonasVautherin @petergerten @julianoes