Follow up for VTOL transition additions

[julianoes]

This follows up on #150 (comment).

[coveralls]

Coverage remained the same at 17.476% when pulling 99abe73 on vtol-fixes into d9bd982 on develop.

[coveralls]

Coverage remained the same at 17.476% when pulling 56c733e on vtol-fixes into d9bd982 on develop.

[hamishwillee]

Remove - incorrect and not needed.

[julianoes]

Thx will do.

[hamishwillee]

BY INSPECTION (not testing)

• minor change to docs in example. I may have others when I actually get round to running this, but I think it looks really solid.
• What will happen on PX4 prior to version with ACK added? I assume that this will still timeout. Should there be a test for version?
• Comments on methods not quite correct - below for the transition to fixed wing:
  Currently
  "The associated action will only be executed for VTOL vehicles in multicopter mode. On other vehicles/modes the command will fail with a Result.".
  Should be (AFAIK):
  "The associated action will only be executed for VTOL vehicles (on other vehicle types the command will fail with a Result). The command will succeed if called when the vehicle is already in fixed-wing mode."

[coveralls]

Coverage remained the same at 17.476% when pulling 0dbc777 on vtol-fixes into 9c6e936 on develop.

[julianoes]

What will happen on PX4 prior to version with ACK added? I assume that this will still timeout. Should there be a test for version?

It will timeout but still work, so not really a problem in my opinion.

Comments on methods not quite correct - below for the transition to fixed wing:

Thanks, fixed.

[coveralls]

Coverage remained the same at 17.476% when pulling fc1111f on vtol-fixes into 9c6e936 on develop.

[hamishwillee]

What will happen on PX4 prior to version with ACK added? I assume that this will still timeout. Should there be a test for version?

It will timeout but still work, so not really a problem in my opinion.

I somewhat disagree, because you're getting a fail error even though the action will actually be executed (if the action was not being executed I'd feel differently). The caller has to "magically" know that this fail is OK.

Your call though.

Otherwise all good.

[julianoes]

I somewhat disagree, because you're getting a fail error even though the action will actually be executed (if the action was not being executed I'd feel differently). The caller has to "magically" know that this fail is OK.

DroneCore does not "officially" support any kind of release yet but is only tested against master. Therefore, we don't need to worry about earlier releases/versions at this point.

[hamishwillee]

Thanks!