Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI sdist tarball no longer contains tests/data folder #132

Closed
frenzymadness opened this issue Nov 9, 2023 · 2 comments · Fixed by #133
Closed

PyPI sdist tarball no longer contains tests/data folder #132

frenzymadness opened this issue Nov 9, 2023 · 2 comments · Fixed by #133

Comments

@frenzymadness
Copy link
Contributor

Hello.

I'm not sure whether this change was intentional but it's no longer possible to run tests with just the content from PyPI:

$ find maxminddb-2.4.0/tests/ | wc -l
52
$ find maxminddb-2.5.0/tests/ | wc -l
3
@frenzymadness
Copy link
Contributor Author

And it also seems that the sdist tarball does not contain the newly bundled libmaxminddb folder so it's not possible to build the extension from the source.

@oschwald
Copy link
Member

oschwald commented Nov 9, 2023

Thanks for reporting this! 2.5.1 was released with a fix.

@oschwald oschwald closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants