Add skip_if_system_missing Bats helper, new get builtin
#114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While beginning to write my first plugin for the framework, I found myself writing utilities to fetch remote files and repositories that I thought would be useful to add to the core builtins. They depend on external programs, but that's par for the course.
The first fix for the `get file` test involves matching `wget` smart quotes using a regex rather than an exact match, since the quote characters appear to vary across systems or `wget` versions. The second fix for the `get git-repo` test involves creating a proper test repo instead of relying on Travis's clone of the framework repo, since it makes a shallow clone of the framework repo but its stock Ubuntu Precise image contains an ancient version of git (1.8) that can't handle cloning shallow repos. See: https://travis-ci.org/mbland/go-script-bash/builds/193181544
|
Hit a couple of interesting corner cases, per usual. See the message from commit 2908c65 for details. |
Another failure from #114, this time because the test repo needs to configure its identity before committing files. See: https://travis-ci.org/mbland/go-script-bash/builds/193200003
|
Pushed another fix in commit 20f3711, because the test repo needs to configure its identity before committing files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While beginning to write my first plugin for the framework, I found myself writing utilities to fetch remote files and repositories that I thought would be useful to add to the core builtins. They depend on external programs, but that's par for the course.