@go.restore_stubbed_core_modules, lib/kcov-ubuntu, and test tweaks
#115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no modules had been stubbed, `@go.restore_stubbed_core_modules` would try to remove the glob pattern itself, resulting in an error message.
Realized a while back that `VAR=foo run "$TEST_GO_SCRIPT"` works just as well as `run env VAR=foo "$TEST_GO_SCRIPT"` and is probably preferable as it saves a process. Don't notice much of an impact on macOS, but hope it improves Windows runs slightly.
In addition to eliminating an array by passing arguments directly to `assert_lines_match`, I also realized it's best to replace the hardcoded `master` reference with `__KCOV_VERSION`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of three small changes I want to merge before a more substantial change to extract
lib/bats-mainin the next PR:@go.restore_stubbed_core_moduleswouldtry to remove the glob pattern itself, resulting in an error message. Now it's a no-op if nothing's been stubbed.
lib/kcov-ubuntuto use the new@go get git-repofrom Addskip_if_system_missingBats helper, newgetbuiltin #114.run env VAR=foowithVAR=foo runeverywhere. Don't notice much of a performance impact on macOS, but it's more consistent with my more recent style and should save a process, which might make more of an impact on Windows.