Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getpinmap_thisboard.cpp #204

Merged
merged 1 commit into from
Feb 10, 2019
Merged

Update getpinmap_thisboard.cpp #204

merged 1 commit into from
Feb 10, 2019

Conversation

cyberman54
Copy link

suppress compiler warning if using custom pin mapping

suppress compiler warning if using custom pin mapping
@frazar
Copy link

frazar commented Jan 29, 2019

Would it make sense to remove the message altogether?
Compilation would fail anyway if lmic_pins is not defined, so the user would know.

@terrillmoore
Copy link
Member

I added this message because if things are misconfigured, beginning users may get a runtime failure due to a nullptr dereference without any way to troubleshoot. #pragma message() is not portable. I agree that if the warning is being emitted when you know what you're doing, it's also annoying, especially if you're not using the routine. It would be better to change this to an LMIC_DEBUG() that warns the user before returning NULL. However, I will merge this now and file a new bug report, as there is no backward-compatibility issue.

@terrillmoore terrillmoore merged commit 4650e89 into mcci-catena:master Feb 10, 2019
@cyberman54 cyberman54 deleted the patch-1 branch February 10, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants