Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the levels displayed in breadcrumbs across the app #5697

Closed
amandacilek-zz opened this issue May 29, 2019 · 9 comments
Closed

Update the levels displayed in breadcrumbs across the app #5697

amandacilek-zz opened this issue May 29, 2019 · 9 comments
Assignees
Labels
Messages Affects the Messages page Priority: 2 - Medium Normal priority Reports Affects the Reports page Type: Improvement Make something better
Milestone

Comments

@amandacilek-zz
Copy link

amandacilek-zz commented May 29, 2019

We use breadcrumbs to display contextual information about where a person/place belongs in the app hierarchy. Depending on the user, sometimes the breadcrumbs can contain redundant and unnecessary information. In this example, I am Amanda Cilek, and "Amanda Cilek's Area" is the place I belong to. I do not need to see "Amanda Cilek's Area" in the breadcrumbs of every single report that I have submitted.
Screen Shot 2019-05-28 at 4 52 21 PM

This request is to update how we handle breadcrumbs so that we show all levels except for the level the user themselves belongs to, the top-most level. The data underneath will still have the entire hierarchy, we'll just choose how much to show based on the logged in user. For example, when I look at my reports tab in the above instance, I should no longer see "Amanda Cilek's Area" at the end of every breadcrumb. However if my manager logged in and looked at the same reports, my manager would still see "Amanda Cilek's Area".

This update should apply to wherever breadcrumbs show on the LEFT HAND SIDE of the app (currently Messages and Reports, but also Tasks once #5710 is done).

Wherever breadcrumbs are shown on the RIGHT HAND SIDE, we should continue to show all breadcrumbs as users often use these as a shortcut to navigate back to the top level.

@MaxDiz
Copy link
Contributor

MaxDiz commented Aug 7, 2019

Hi @garethbowen This issue should be completed alongside #5710 (currently scheduled in v3.8) to make it functional. I also have a call with @amandacilek and @yembrick this week to review any outstanding design work on these issues and will report back

@garethbowen
Copy link
Member

Ok. Adding to 3.8.0.

@maremegaye
Copy link

From the above Amanda’s post to now few breadcrumbs have been deleted. Hereunder a table that describes the breadcrumbs deleted and those not deleted across different users and different projects.

  • For the CHW, we will need to delete the breadcrumbs in the report tab
  • For the Supervisor, we will delete the breadcrumbs in the report and message tabs
  • For the Admin view, we will need to delete the breadcrumbs of the message tab

https://docs.google.com/document/d/1t9wSTpNHnxyprVy-EX5MxGD8_YMTZ1qIZrg9gVb93LQ/edit

@garethbowen
Copy link
Member

Moved to 3.12.0 to free up engineers to work on 3.11.0.

@MaxDiz
Copy link
Contributor

MaxDiz commented Jul 9, 2020

removing from v3.12 so can be considered alongside #5997 and #5886 (to be scheduled)

@latin-panda
Copy link
Contributor

Hi @michaelkohn and @elvisdorkenoo

Have you defined where the changes are going to be (ie messages, targets, contacts, reports) and what we expect to see?

I see the PR is on the way, this information will help the Code Review and AT. Thanks!

@elvisdorkenoo
Copy link
Contributor

elvisdorkenoo commented Aug 29, 2022

hello @latin-panda,

Have you defined where the changes are going to be (ie messages, targets, contacts, reports) and what we expect to see?

Yes, the last two paragraphs of the issue description are added by @michaelkohn to give more clarifications.

@latin-panda
Copy link
Contributor

Cool!
I didn't notice the issue's description was updated, because I read it few weeks ago then I assumed it was the same and I was looking for a new comment with updated info.
Thanks for the clarification!

@michaelkohn michaelkohn added this to the 3.17.0 milestone Sep 8, 2022
@elvisdorkenoo elvisdorkenoo moved this from In Progress to Ready for AT in Product Team Activities Sep 20, 2022
@ngaruko ngaruko moved this from Ready for AT to AT in Progress in Product Team Activities Sep 20, 2022
@ngaruko ngaruko self-assigned this Sep 20, 2022
@bedengaruko
Copy link

bedengaruko commented Sep 22, 2022

  1. Created a new hierarchy : Health Centre > Area > Household > Person
  2. Submitted a couple of reports for the person
  3. Submitted a task generating report for the person (pregnancy)
  4. Note results
    >> Online user sees the whole hierarchy

image

_**>> Offline user does not see area, only household (on the LHS) >>**_

image

>> Same with Tasks
image
>> Messages Tab >
image

@ngaruko ngaruko moved this from AT in Progress to Ready to Merge in Product Team Activities Sep 22, 2022
@latin-panda latin-panda added Messages Affects the Messages page Reports Affects the Reports page and removed Tasks Affects the Tasks page labels Sep 22, 2022
elvisdorkenoo added a commit that referenced this issue Sep 22, 2022
)

This commit updates how we handle breadcrumbs so that we show all levels except for the level the user(offline) themselves belongs to.
@elvisdorkenoo elvisdorkenoo moved this from Ready to Merge to Done in Product Team Activities Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Messages Affects the Messages page Priority: 2 - Medium Normal priority Reports Affects the Reports page Type: Improvement Make something better
Projects
Status: Done
Development

No branches or pull requests

9 participants