Add crop marker support #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
added
the
skip-changelog
bidoubiwa
added
enhancement
meili-bors bot
added a commit
that referenced
this pull request
May 9, 2022
749: Update version for the next release (v0.7.1) r=brunoocasali a=bidoubiwa This version makes this package compatible with Meilisearch v0.27.0 🎉 Check out the changelog of [Meilisearch v0.27.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.27.0) for more information on the changes. ## 🚀 Enhancements - Add highlight prefix suffix tags #739 - Add crop marker support #738 Thanks again to `@bidoubiwa` and `@mmachatschek!` 🎉 Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Previously instant-meilisearch added crop markers in the specific fields depending on the
snippetEllipsisTextvalue provided by theconfigurationwidget of instantsearch. The injection of the markers was done by instant-meilisearch. Now it is added as the query parametercropMarkerto the search request where the markers are added by meilisearch the engine.Some tests have been removed as they where not relevant.