Add highlight prefix suffix tags #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
update_snippeting_resolver
to
bump-meilisearch-v0.27.0
April 21, 2022 14:03
bidoubiwa
force-pushed
the
add_highlight_prefix_suffix
branch
from
e8969ec to
c950afe
Compare
bidoubiwa
added
the
skip-changelog
alallema
reviewed
Apr 25, 2022
Comment on lines
+242
to
+245
| if (hit?.title) { | ||
| expect(hit?.title?.value).toEqual('Ariel') | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't understand how you get this result with your query?
There was a problem hiding this comment.
It is from inside the nested object!
expect(hit?.objectArray[0]?.name.value).toEqual(
'__ais-highlight__hello__/ais-highlight__ world'
)
meili-bors bot
added a commit
that referenced
this pull request
May 9, 2022
749: Update version for the next release (v0.7.1) r=brunoocasali a=bidoubiwa This version makes this package compatible with Meilisearch v0.27.0 🎉 Check out the changelog of [Meilisearch v0.27.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.27.0) for more information on the changes. ## 🚀 Enhancements - Add highlight prefix suffix tags #739 - Add crop marker support #738 Thanks again to `@bidoubiwa` and `@mmachatschek!` 🎉 Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
3 tasks
meili-bors bot
added a commit
that referenced
this pull request
Jul 10, 2024
1306: instant-meilisearch: Fix _matchesPosition not being included in hits r=brunoocasali a=mavcook # Pull Request ## Related issue Fixes #1305 ## What does this PR do? Corrects _matchesPosition field not being included in each hit when meiliSearchParam.showMatchesPosition=true ### Regression This bug was introduced in PR #739, release [0.7.1](https://github.com/meilisearch/meilisearch-js-plugins/releases/tag/v0.7.1), which just seems to have been a typo/forgetting to include _matchesPosition, as you can see it was included in the destructured assignment, but not used. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Co-authored-by: mavcook <16587643+mavcook@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Previously instant-meilisearch changed the default
<em>tags in the specific fields depending on thehighlightPreTagandhighlightPostTagvalue provided by theconfigurationwidget of instantsearch.The replacement of the HTML tags was done by instant-meilisearch. Now, you can provide custom tags to Meilisearch which will use these instead of the previous
em.