Skip to content

Replace frame 289 with the correct last frame 389 #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

Replace frame 289 with the correct last frame 389 #876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/resources/nasa_13013.mp4.stream3.frame000289.pt
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions test/test_decoders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ def test_getitem_int(self, num_ffmpeg_threads, device, seek_mode):
ref_frame0 = NASA_VIDEO.get_frame_data_by_index(0).to(device)
ref_frame1 = NASA_VIDEO.get_frame_data_by_index(1).to(device)
ref_frame180 = NASA_VIDEO.get_frame_data_by_index(180).to(device)
ref_frame_last = NASA_VIDEO.get_frame_data_by_index(289).to(device)
ref_frame_last = NASA_VIDEO.get_frame_data_by_index(389).to(device)

assert_frames_equal(ref_frame0, decoder[0])
assert_frames_equal(ref_frame1, decoder[1])
Expand All @@ -193,7 +193,7 @@ def test_getitem_numpy_int(self):
ref_frame0 = NASA_VIDEO.get_frame_data_by_index(0)
ref_frame1 = NASA_VIDEO.get_frame_data_by_index(1)
ref_frame180 = NASA_VIDEO.get_frame_data_by_index(180)
ref_frame_last = NASA_VIDEO.get_frame_data_by_index(289)
ref_frame_last = NASA_VIDEO.get_frame_data_by_index(389)

# test against numpy.int64
assert_frames_equal(ref_frame0, decoder[numpy.int64(0)])
Expand Down Expand Up @@ -404,7 +404,7 @@ def test_iteration(self, device, seek_mode):
ref_frame9 = NASA_VIDEO.get_frame_data_by_index(9).to(device)
ref_frame35 = NASA_VIDEO.get_frame_data_by_index(35).to(device)
ref_frame180 = NASA_VIDEO.get_frame_data_by_index(180).to(device)
ref_frame_last = NASA_VIDEO.get_frame_data_by_index(289).to(device)
ref_frame_last = NASA_VIDEO.get_frame_data_by_index(389).to(device)

# Access an arbitrary frame to make sure that the later iteration
# still works as expected. The underlying C++ decoder object is
Expand Down
4 changes: 2 additions & 2 deletions test/test_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ def test_throws_exception_at_eof(self, device):

seek_to_pts(decoder, 12.979633)
last_frame, _, _ = get_next_frame(decoder)
reference_last_frame = NASA_VIDEO.get_frame_data_by_index(289)
reference_last_frame = NASA_VIDEO.get_frame_data_by_index(389)
assert_frames_equal(last_frame, reference_last_frame.to(device))
with pytest.raises(IndexError, match="no more frames"):
get_next_frame(decoder)
Expand Down Expand Up @@ -1059,7 +1059,7 @@ def seek(self, offset: int, whence: int) -> int:
seek_to_pts(decoder, 12.979633)

frame_last, *_ = get_next_frame(decoder)
reference_frame_last = NASA_VIDEO.get_frame_data_by_index(289)
reference_frame_last = NASA_VIDEO.get_frame_data_by_index(389)
assert_frames_equal(frame_last, reference_frame_last.to(device))

assert file_counter.num_seeks > initialization_seeks
Expand Down
Loading